http://codingclues.disqus.com/enWed, 25 Jun 2008 01:40:46 -0000http://codingclues.eu/2008/the-perfect-job-interview-question/#comment-3855751My answer: lack of tests. <br> <br>Kind RegardsMarcos Silva PereiraWed, 25 Jun 2008 01:40:46 -0000http://codingclues.eu/2008/the-perfect-job-interview-question/#comment-3855750that is an terrible answer. I have seen too many (often young students) look at a piece of code (such as part of Eclipse) and say the architecture is bad. Only to look back 3 years later (and now using, extending, and working with eclipse), and say, WOW, this is so well designed. <br> <br>It is very difficult to see the forest through the trees, especially when you are looking at a small part of the system. What if you were reviewing someones implementation of a sort algorithm, or collection of SQL queries; does the architecture matter here? Is it good if they use the latest architectural style or quote something from design patterns? Architecture and design is very subjective and always in the eye of the beholder. <br> <br>Honestly, the thing I find most disturbing when reviewing someone else's code is when they can't explain what they did, or why they did it. Be-it a small (few line change) or a refactoring of the "architecture", if the developer cannot explain (without a lot of hand waving and well-you know, kinda, like, you know, it does the, you-know so we can, you-know cache or something) what they did... alarm bells go off immediately. <br> <br>just my $0.02.ianWed, 25 Jun 2008 00:32:29 -0000